-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for Python 3.14 #10467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.14 #10467
Conversation
Blocked by pylint-dev/astroid#2789 |
This comment has been minimized.
This comment has been minimized.
0c3a320
to
fa3ae5a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a5614d4
to
44d6fc2
Compare
#10480 will help resolve a lot of the issues here. On the astroid side I just created pylint-dev/astroid#2793 to add basic support for |
This comment has been minimized.
This comment has been minimized.
44d6fc2
to
daf1483
Compare
This comment has been minimized.
This comment has been minimized.
Not blocked anymore with astroid 4.0.0b1. Not sure how to best deal with the no-member / no-name-in-module though. I'm not sure that the conditional functional test based on the interpreter are going to work for the expected output too. |
This comment has been minimized.
This comment has been minimized.
Will take a proper look at it soon. It at least uncovered a false-positive for |
CI is looking good now. Interestingly I'm still getting an error locally. pytest tests/test_functional.py::test_functional[regression_5408] Crashes with |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10467 +/- ##
=======================================
Coverage 95.86% 95.87%
=======================================
Files 176 176
Lines 19168 19168
=======================================
+ Hits 18376 18377 +1
+ Misses 792 791 -1
🚀 New features to boost your workflow:
|
Amazing ! Regarding the abort trap, I don't know, but I think that's outside pylint's purview. I don't remember if I was the one who removed the new "Forward" functional tests specifically for 3.14 or if it was you (importing from annotationlib instead of typing), do you think it make sense to add it back ? |
Would you mind running the test on your machine? If the error is more common, it might still be related / caused by pylint or astroid. Though at the moment I suspect it's just some issue on my machine.
I removed it while pushing 8c4750a. It's not really necessary since with pylint-dev/astroid#2795, |
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 8853532 |
Sure, but I have ubuntu 24.04.2 LTS (tested with python 3.14 alpha 6 and python 3.14 rc1 installed with uv), no crashes.
"revealed" right ? As in it's a bug in cpython that we can maybe avoid triggering with some guesswork ? |
Yeah, if it was just on my machine it's probably nothing. However, if it can be reproduced reliably that's a different story. Removing these lines here is enough for the error to go away but that's not really the point. pylint/tests/functional/r/regression_02/regression_5408.py Lines 35 to 37 in d363fca
Looks like I need to investigate that a bit further. -- |
Type of Changes