Skip to content

[Backport maintenance/3.3.x] Use custom Github App to authenticate backport job #10396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025

Conversation

pylint-backport-bot[bot]
Copy link

Backport 6be8676 from #10394.

@cdce8p
Copy link
Member

cdce8p commented May 18, 2025

What do you guys think @Pierre-Sassoulas @DanielNoord ?

The only small thing left would be to change the commit author in the tibdex/backport action. It's still set to github-actions[bot]@users.noreply.github.com. At least for squash merge commits that shouldn't really matter though with

This commit will be authored by 212256041+pylint-backport-bot[bot]@users.noreply.github.com.

https://github.com/tibdex/backport/blob/main/src/backport.ts#L260-L266

@cdce8p cdce8p added the Maintenance Discussion or action around maintaining pylint or the dev workflow label May 18, 2025
@DanielNoord
Copy link
Collaborator

LGTM!

@Pierre-Sassoulas
Copy link
Member

LGTM, that would be for style point, we already have 150+ commits from github actions bot and the co-author is properly set anyway. (Beside we do not control the tidbex/backport so it could take some time)

Copy link

codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (7038ef4) to head (526eb86).
Report is 1 commits behind head on maintenance/3.3.x.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           maintenance/3.3.x   #10396   +/-   ##
==================================================
  Coverage              95.84%   95.84%           
==================================================
  Files                    174      174           
  Lines                  18999    18999           
==================================================
  Hits                   18210    18210           
  Misses                   789      789           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdce8p
Copy link
Member

cdce8p commented May 18, 2025

LGTM, that would be for style point, we already have 150+ commits from github actions bot and the co-author is properly set anyway.

The author for the squash-merge commit will be fine as well. It's just 526eb86 that's not entirely correct.

(Beside we do not control the tidbex/backport so it could take some time)

True. No commits in over two years. We would probably have to fork it into the pylint-dev org but that could be done. Making the author configurable should be fairly strait forward.

@Pierre-Sassoulas
Copy link
Member

We would probably have to fork it into the pylint-dev org but that could be done.

There's also some advantages of not having to review new versions or worry about supply chain attacks.

If you want to do it and it seems you want to do it, let's do it 😉

@cdce8p cdce8p merged commit 329c967 into maintenance/3.3.x May 18, 2025
24 checks passed
@cdce8p cdce8p deleted the backport-10394-to-maintenance/3.3.x branch May 18, 2025 21:34
@cdce8p
Copy link
Member

cdce8p commented May 18, 2025

If you want to do it and it seems you want to do it, let's do it 😉

I'll probably finish #10382 first but after that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants