-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Backport maintenance/3.3.x] Use custom Github App to authenticate backport job #10396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit 6be8676)
What do you guys think @Pierre-Sassoulas @DanielNoord ? The only small thing left would be to change the commit author in the
https://github.com/tibdex/backport/blob/main/src/backport.ts#L260-L266 |
LGTM! |
LGTM, that would be for style point, we already have 150+ commits from github actions bot and the co-author is properly set anyway. (Beside we do not control the tidbex/backport so it could take some time) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maintenance/3.3.x #10396 +/- ##
==================================================
Coverage 95.84% 95.84%
==================================================
Files 174 174
Lines 18999 18999
==================================================
Hits 18210 18210
Misses 789 789 🚀 New features to boost your workflow:
|
The author for the squash-merge commit will be fine as well. It's just 526eb86 that's not entirely correct.
True. No commits in over two years. We would probably have to fork it into the |
There's also some advantages of not having to review new versions or worry about supply chain attacks. If you want to do it and it seems you want to do it, let's do it 😉 |
I'll probably finish #10382 first but after that 😄 |
Backport 6be8676 from #10394.