🧪 Add a test for implicit ns src root lookup #10171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch modifies the `test_discover_package_path_source_root_as_*` tests to also run against directory layouts with no exlicitly existing `__init__.py` file. They were added in pylint-dev#10036 and seem to be insufficient, not covering PEP 420 implicit namespaces.
|
@DanielNoord @Pierre-Sassoulas it's not failing where I thought it would.. But perhaps it's still worth merging. WDYT? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10171 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 174 174
Lines 18995 18995
=======================================
Hits 18204 18204
Misses 791 791 |
Pierre-Sassoulas
added
Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies the
test_discover_package_path_source_root_as_*tests to also run against directory layouts with no exlicitly existing__init__.pyfile.They were added in #10036 and seem to be insufficient, not covering PEP 420 implicit namespaces.
Type of Changes
Description
I haven't found a pre-existing issue so far. It should be possible to mark these tests with xfail and merge them before working on the actual fix.