Bump astroid from 3.3.5 to 3.3.8 #10125
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependency
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
force-pushed
the
dependabot/pip/astroid-3.3.6
branch
from
244fbb0 to
1fc607c
Compare
Bumps [astroid](https://github.com/pylint-dev/astroid) from 3.3.5 to 3.3.7. - [Release notes](https://github.com/pylint-dev/astroid/releases) - [Changelog](https://github.com/pylint-dev/astroid/blob/main/ChangeLog) - [Commits](pylint-dev/astroid@v3.3.5...v3.3.7) --- updated-dependencies: - dependency-name: astroid dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Pierre Sassoulas <[email protected]>
Pierre-Sassoulas
force-pushed
the
dependabot/pip/astroid-3.3.6
branch
from
1fc607c to
d73e0a7
Compare
Pierre-Sassoulas
changed the title
|
@DanielNoord any chance you would be able to look into the primer failure? My guess is that we can't lint the module ending with |
|
A newer version of astroid exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
@jacobtylerwalls How should I interpret the failure? I don't really understand how it fails on |
|
I can reproduce the 3.11 stdlib failure with just: python3.11 -m pytest -m primer_stdlib --primer-stdlib |
|
And the 3.13 primer failure on django, I just navigate to my local checkout of django I also happen to have (assume it's the same if I were to go to the pylint primer tests checkout): python3.13 -m pylint django.contrib.gis.geos.io |
I set a breakpoint on the 3.3.7 changes and notice that we iterate from the right, e.g. we parse |
|
But the I would be more surprised if it actually returned a |
|
Why would the in stdlib test pass for a django submodule? (Pdb) processed
('django', 'contrib', 'gis', 'geos')
(Pdb) modname
'io'
(Pdb) modname in sys.stdlib_module_names
True |
jacobtylerwalls
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10125 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 174 174
Lines 18972 18976 +4
=======================================
+ Hits 18176 18180 +4
Misses 796 796 |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-10125-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 31e7674ad44c9cbd3120e7e42497bf8af911df79
# Push it to GitHub
git push --set-upstream origin backport-10125-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.xThen, create a pull request where the |
(cherry picked from commit 31e7674)
Bump astroid to 3.3.8