Skip to content

Add Django 5.2 support #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

scpaes
Copy link

@scpaes scpaes commented May 29, 2025

@coveralls
Copy link

coveralls commented May 30, 2025

Pull Request Test Coverage Report for Build 16200018383

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.27%

Totals Coverage Status
Change from base Build 15843151956: 0.0%
Covered Lines: 741
Relevant Lines: 869

💛 - Coveralls

@Pierre-Sassoulas
Copy link
Member

Look like CI on main became broken and pre-commit too. Change LGTM, otherwise. (You can make the branch writtable by contributors so we can handle little things for you)

@scpaes
Copy link
Author

scpaes commented May 30, 2025

Look like CI on main became broken and pre-commit too. Change LGTM, otherwise. (You can make the branch writtable by contributors so we can handle little things for you)

@Pierre-Sassoulas Thank you for the review! I’d like to try fixing the CI errors myself first. If I need any help, I’ll reach out here. If I’m not able to resolve the issues, I’ll make my branch available for contributors.

@scpaes
Copy link
Author

scpaes commented Jul 10, 2025

Look like CI on main became broken and pre-commit too. Change LGTM, otherwise. (You can make the branch writtable by contributors so we can handle little things for you)

@Pierre-Sassoulas It looks like the test_latest CI job is failing due to an upstream dependency conflict between the main branches of pylint and astroid.

Screenshot 2025-07-10 at 13 10 03
Running command git clone --filter=blob:none --quiet https://github.com/pylint-dev/astroid /private/var/folders/mc/8q9wrds13_gfx93btxlwtj3r0000gn/T/pip-req-build-axa3kt_k
  Running command git clone --filter=blob:none --quiet https://github.com/pylint-dev/pylint /private/var/folders/mc/8q9wrds13_gfx93btxlwtj3r0000gn/T/pip-req-build-e1dk8am0                                                                                                                                                                                                                                                                          
ERROR: Cannot install astroid 4.0.0.dev1 (from git+https://github.com/pylint-dev/astroid@main) and pylint==4.0.0.dev0 because these package versions have conflicting dependencies.

@Pierre-Sassoulas
Copy link
Member

The fix is to rely on bleeding edge pylint only and remove the dependency to bleeding edge astroid. Bleeding edge pylint should control its dependencies. And having bleeding edge pylint be always compatible with bleeding edge astroid is something pylint is not able to guarantee in a reasonable amount of time for a reasonable amount of maintainer time. (And impossible to always be true when there's breaking changes in astroid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants