Extend filter_column_isin to support multi-column and dict-based API #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… introduction in index.md Updated description of 'pyjanitor' to emphasize user-friendly API.
for more information, see https://pre-commit.ci
Adds filter_column_isin back to filter.py with the following improvements: 1. Supports single-column, multi-column, and dict-based filtering 2. Keeps backward compatibility for single-column usage 3. Adds complement flag for inverse filtering Addresses issue pyjanitor-devs#1476
for more information, see https://pre-commit.ci
|
Thanks @chentalia317-alt we are still having a conversation on whether this function should be deprecated and point users to the pandas' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1476
Summary: reintroduces and extends filter_column_isin in filter.py.
Supports Single-column, multi-column, and dict-based filtering
Adds complement flag for inverse filtering.