Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install-pyenv-win.ps1 #604

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ezhil56x
Copy link

Without closing powershell pyenv can be used as soon as it is installed

@ezhil56x ezhil56x requested a review from a team as a code owner March 31, 2024 21:15
@luchihoratiu
Copy link
Contributor

Hi @ezhil56x!

I found your proposal extremely useful (I am currently using Chocolatey's refreshenv command to bypass this issue) so I tried your changes in combination with #602, but I get the following error:
image

Creating the $PROFILE file before installing pyenv gets rid of the error but doesn't help with the end goal:
image


I would suggest running cat $PROFILE on your PC and investigate why this is working for you.


If anyone wants to reproduce this, see #601 but replace step 4 with:

Invoke-WebRequest -UseBasicParsing -Uri "https://raw.githubusercontent.com/luchihoratiu/pyenv-win/test/pr-604/pyenv-win/install-pyenv-win.ps1" -OutFile "./install-pyenv-win.ps1"; &"./install-pyenv-win.ps1"

Changes can be checked at: https://github.com/luchihoratiu/pyenv-win/commits/test/pr-604/

@ezhil56x
Copy link
Author

ezhil56x commented Apr 1, 2024

Hi @luchihoratiu
Just noticed that I have custom Powershell script mapped, so it works fine. Will figure out a way and update/close my PR

@ezhil56x
Copy link
Author

ezhil56x commented Apr 1, 2024

@luchihoratiu
Fixed

@luchihoratiu
Copy link
Contributor

image
🤕

Invoke-WebRequest -UseBasicParsing -Uri "https://raw.githubusercontent.com/luchihoratiu/pyenv-win/test/pr-604-nr2/pyenv-win/install-pyenv-win.ps1" -OutFile "./install-pyenv-win.ps1"; &"./install-pyenv-win.ps1"

Code owners might've tackled this topic in the past and have some ideas.

@ezhil56x
Copy link
Author

ezhil56x commented Apr 1, 2024

The only thing I think will work is to create a Powershell profile for the user and use . $PROFILE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants