use watchfiles

[bollwyvl]

Elevator Pitch

This strawman PR replaces ipynotify and macfsevents with the more-supported watchfiles, implemented in rust under the hood, which also works on windows.

References

• based on Move "auto" command out of core package. doit#424
• fixes implement cmd auto on Windows doit#17

Code Changes

• depend on watchfiles
• use watchfiles
• remove platform-specific handling and test skips
• simplify event masking, etc
  • some of these could be restored, though the range of events is far smaller (see below)

Breaking Changes

• the signature of handle_event is entirely different
  • it now receives a set of (change, path) pairs, where change is one of 1 (add), 2 (delete), or 3 (modify)
• the no-longer-tested loop_callback is removed

Possible Work: on this PR or future

• more of the previous handle_event(event) signature could be emulated
• the loop_callback behavior could be restored with yield_on_timeout (it yields an empty set)

Thanks again for doit!

[schettino72]

Cool. thanks. Have not looked in detail but code looks much cleaner.

Just that my idea was to fork this plugin and create a new one for watchfiles.

And I wondering I if should call it doit-watch instead of auto,
it seems it is a much more common name for such functionality (specially given the underlying lib).

What do you think?

[bollwyvl]

Yep: lots of choices, just wanted to get stuff I had tinkered with out there to start.

create a new one for watchfiles.

Yeah, that's the best part of splitting it out of core.

doit-watch instead of auto,

Yes, that makes sense.