Fix incorrect type annotations, add py.typed. #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you'd prefer one big patch lmk. I'm working through getting Liberation up to the latest and finding a lot of little things. |
|
hmm maybe one PR with multiple commits, not sure its useful to have 1 PR per commit, until something depends on it. |
|
Can do. Will finish up my migration and then send them in a batch. I'm done for the day though so you have a reprieve :) |
This is an integer in the mission file, not a string.
Allows using these properties without knowing the exact type of the vehicle.
DanAlbert
force-pushed
the
fix-mission-constructor
branch
from
be5d0bf to
ee2775e
Compare
DanAlbert
changed the title
|
Okay, ready to go. Checks another box on #160. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits together are the errors I found while updating Liberation to type check our uses of pydcs. In one case there was an actual bug (loading a mission with a refuel/rearm landing waypoint and then resaving it would corrupt the mission by writing a string back where an integer was needed).
This also adds the py.typed file, without which mypy ignore type annotations in this package when checking dependents: https://mypy.readthedocs.io/en/stable/installed_packages.html#creating-pep-561-compatible-packages