Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ answer about API stability & backwards compatibility #9855

Merged
merged 21 commits into from
Jan 30, 2025

Conversation

TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented Dec 4, 2024


Xarray tries very hard to maintain backwards compatibility in our :ref:`api` between released versions.
Whilst we do occasionally make breaking changes in order to improve the library,
we try to `signpost changes <https://docs.xarray.dev/en/stable/contributing.html#backwards-compatibility>`_ with ``DeprecationWarnings`` for many months in advance.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
we try to `signpost changes <https://docs.xarray.dev/en/stable/contributing.html#backwards-compatibility>`_ with ``DeprecationWarnings`` for many months in advance.
we `signpost changes <https://docs.xarray.dev/en/stable/contributing.html#backwards-compatibility>`_ with ``DeprecationWarnings`` for many releases in advance.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or

Suggested change
we try to `signpost changes <https://docs.xarray.dev/en/stable/contributing.html#backwards-compatibility>`_ with ``DeprecationWarnings`` for many months in advance.
our policy is to `signpost changes <https://docs.xarray.dev/en/stable/contributing.html#backwards-compatibility>`_ with ``DeprecationWarnings`` for many releases in advance.

Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a formatting error to fix: home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/9855/doc/getting-started-guide/faq.rst:431: WARNING: Duplicate explicit target name: "public api".

@kmuehlbauer
Copy link
Contributor

This is really needed as a reference in the documentation. I pushed a fix to get RTD running again. Would be nice to get this in.

@kmuehlbauer kmuehlbauer mentioned this pull request Jan 29, 2025
@kmuehlbauer kmuehlbauer enabled auto-merge (squash) January 30, 2025 16:51
Copy link
Member Author

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @kmuehlbauer - I just noticed one typo

@kmuehlbauer kmuehlbauer merged commit 326dbe7 into pydata:main Jan 30, 2025
28 checks passed
@kmuehlbauer
Copy link
Contributor

Thanks @TomNicholas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FAQ answer about API stability / backwards compatibility?
4 participants