-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Switch from sphinx-llms-txt => sphinx-llm
#11003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from sphinx-llms-txt => sphinx-llm
#11003
Conversation
|
I suspect the first build failed because the two parallel builds collided in some way. I've run it a couple of times locally and it builds sometimes and fails others, this is certainly some kind of race condition. Perhaps notebooks being executed clobbered each other or something. I can think of a couple of ways forward:
|
for more information, see https://pre-commit.ci
|
Yeah it looks like some xarray/doc/getting-started-guide/quick-overview.rst Lines 214 to 226 in f252119
To fix this it would be best if these cells used unique tempdirs, but that might also overcomplicate the examples. Caring about thread safety in your docs builds might just increase maintainability in a way you don't want. I've just released |
|
Thanks Jacob, seems like an improvement to me! Making those cells thread-safe would be a good improvement too IMO. |
|
Ok great. It might be best to merge this as is, then I can make a follow up PR to make those cells thread safe and change the config back to a parallel build. |
* main: Switch from `sphinx-llms-txt` => `sphinx-llm` (pydata#11003) Backend fastpath (pydata#10937) Change behavior of `keep_attrs` in `xr.where` when x is a scalar (pydata#10997) make error message more clear (pydata#10994) Address pandas-related upstream errors in pydata#10973 (pydata#10988) new release section (pydata#10985) set the release date (pydata#10984) release v2025.12.0 (pydata#10981) Add sphinx-llms-txt (pydata#10978)
#10978 added
llms.txtsupport, however, as this repo makes heavy use of extensions and directives in the docs includingautodoc,autosummary,nbsphinxand more I just wanted to point out that the current extension you're usingsphinx-llms-txtdoesn't support these in thellms.txtoutput. It simply copies the docs source through in the original format.I've also been working on an extension that generates
llms.txtfiles called sphinx-llm, but it does so by running a parallel sphinx build in the background using themarkdownbuilder. It builds markdown versions of every page, this includes autogenerated pages, and all use of extensions and directives. You can append.mdto any docs URL to see the markdown version of the page. Not every extension is supported by the markdown builder, but it does a pretty good job. It then concatenates these into thellms-full.txtand generates thellms.txtsitemap too. As sphinx is single-threaded this has no build time impact on systems with at least two cores.The author of
sphinx-llms-txtand I have discussed this and I proposed merging the two projects. However they have said the waysphinx-llms-txtpasses the source through is by design and they don't have any interest in collaborating.As xarray uses extensions and directives I wanted to propose switching to my extension. But no problem either way.
Disclaimer: In case it's not clear I am the author of
sphinx-llmso this is a self-serving PR, but I think it will benefit xarray.cc @dcherian @VeckoTheGecko