Add boundaries keyword for resample #10865
Open
+94
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
reviewed
Oct 18, 2025
| offset: pd.Timedelta | datetime.timedelta | str | None, | ||
| origin: str | DatetimeLike, | ||
| restore_coord_dims: bool | None, | ||
| boundaries: Literal["exact", "trim"] | None = None, |
There was a problem hiding this comment.
shall we use drop_incomplete: bool like in SeasonResampler? Note that you could be missing data in the middle too...
dcherian
reviewed
Oct 18, 2025
dcherian
reviewed
Oct 18, 2025
xarray/core/common.py
Outdated
Comment on lines
1147
to
1149
| unique_counts, count_frequencies = np.unique( | ||
| counts, return_counts=True | ||
| ) |
There was a problem hiding this comment.
This seems wrong, for example what about a time series starting or ending in february --- this will always have fewer points even if all of february is included
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstapi.rst