Fix dataarray drop attrs #10030
Open
Fix dataarray drop attrs #10030
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
for more information, see https://pre-commit.ci
headtr1ck
requested changes
Feb 7, 2025
| ) | ||
| if not deep: | ||
| for k in list(self.attrs): | ||
| del self.attrs[k] |
There was a problem hiding this comment.
That changes the data array inplace which is something we try to avoid.
Can you return a copy instead while leaving the original one intact?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to Issue #10027
It fixes the issue and adds tests to prevent similar issues in future.
whats-new.rstI did not document the change in whats-new.
I'm also not 100 % happy with the solution. I would welcome an experienced contributor to review the changes.