deprecate cftime_range() in favor of date_range(use_cftime=True) #10024
Conversation
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
- update other examples that call cftime_range to use date_range(use_cftime=True) instead Issue pydata#9886
…array into cftime_deprecation merging with head.
Fix typo in pull request number
for more information, see https://pre-commit.ci
…array into cftime_deprecation merging what's new changes
- Fix bug in copy/paste bug in cftime_offsets.
type checking is enabled - change the example for cftime_range to use date_range(use_cftime) instead to get around deprecation warnings
per code review issue pydata#9886 Co-authored-by: Maximilian Roos <[email protected]>
There was a problem hiding this comment.
Great, @Maddogghoek! Small change, big impact, thanks for tackling this!
Just one question and one suggestion. Hope this attracts more reviewers.
Fix typo in (s/true/True) in what's new for issue pydata#9886 change. Co-authored-by: Kai Mühlbauer <[email protected]>
There was a problem hiding this comment.
Thanks for taking this on @Maddogghoek! It took me a moment to follow the additional refactoring within _cftime_range, but generally I think those changes are incremental improvements, so I am OK to leave them in. I have a few nits and some documentation suggestions, but otherwise this is looking good.
Update documentation to steer users to xarray.date_range rather than deprecated xarray.cftime_range. Co-authored-by: Spencer Clark <[email protected]>
for more information, see https://pre-commit.ci
listed under deprecations instead Co-authored-by: Spencer Clark <[email protected]>
Co-authored-by: Spencer Clark <[email protected]>
…ls.emit_user_level_warning rather than warnings.warn
Co-authored-by: Spencer Clark <[email protected]>
…array into cftime_deprecation
There was a problem hiding this comment.
Thanks @Maddogghoek! I appreciate your careful attention to detail on this. A couple more minor suggestions, but otherwise this looks good to me.
|
|
||
| warn( | ||
| emit_user_level_warning( |
There was a problem hiding this comment.
Nice, thanks for updating this in the contributing guide!
Co-authored-by: Spencer Clark <[email protected]>
(pydata#9886) Co-authored-by: Spencer Clark <[email protected]>
(pydata#9886) Co-authored-by: Spencer Clark <[email protected]>
be more explicit about the valid combinations of start, end, periods, and freq. Co-authored-by: Spencer Clark <[email protected]>
for more information, see https://pre-commit.ci
pydata#9886 Co-authored-by: Kai Mühlbauer <[email protected]>
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
|
Thanks @Maddogghoek welcome to Xarray! |
xr.cftime_rangein favor ofxr.date_range#9886whats-new.rstNo functional changes beyond a deprecation warning, so no test changes.