Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash in DesignMatrix.__repr__ when shape[0] == 0 #83

Merged
merged 1 commit into from
Apr 7, 2016
Merged

Fix a crash in DesignMatrix.__repr__ when shape[0] == 0 #83

merged 1 commit into from
Apr 7, 2016

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Apr 6, 2016

Discovered by @rsgmon in gh-82.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 97.701% when pulling bfe145b on njsmith:fix-DesignInfo-zero-rows-repr into f9ad38b on pydata:master.

@njsmith
Copy link
Member Author

njsmith commented Apr 7, 2016

Test failures are because doing conda install pandas=0.14.0 apparently produces a totally broken conda environment (import numpy -> error: libgfortran not found; see Travis logs). Odd. I don't think we should stop testing patsy on pandas 0.14.0 yet -- at least not without ripping out all the old support code for it! -- but I don't want to deal with this right now, so I guess I'll merge and worry about it later.

@jreback: I feel like I should bring this weird brokenness in anaconda to someone's attention, but I'm not sure who, and you hit my intersection of pandas + continuum + conda advocate :-)

@njsmith njsmith merged commit 0db7dda into pydata:master Apr 7, 2016
@jreback
Copy link

jreback commented Apr 7, 2016

yeah IIRC there was an issue with some meta data in the dependencies in older numpies, you can make this work by forcing

libfortran=1.0

e.g. conda install -n pt numpy==1.8.2 libfortran==1.0 (only needed for linux)

@jreback
Copy link

jreback commented Apr 7, 2016

conda/conda#444

njsmith added a commit to njsmith/patsy that referenced this pull request Apr 8, 2016
@njsmith
Work around anaconda gfortran dependency bug
f51cc8c 
For details see:
  pydata#83 (comment)
and replies.

Thanks to @jreback for the fix.
@njsmith njsmith mentioned this pull request Apr 8, 2016
Merged
njsmith added a commit to njsmith/patsy that referenced this pull request Apr 8, 2016
@njsmith
Work around anaconda gfortran dependency bug
ceb9ac8 
For details see:
  pydata#83 (comment)
and replies.

Thanks to @jreback for the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njsmith @coveralls @jreback