Skip to content

Expose AWS Secrets Manager case sensitive option #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

femiadebayo
Copy link

#628

The "pydantic-settings[aws-secrets-manager]" integration does not expose the case_sensitive parameter in it's API. It defaults to True and cannot be changed.

/pydantic_settings/sources/providers/aws.py

class AWSSecretsManagerSettingsSource(EnvSettingsSource):
def init(
self,
settings_cls: type[BaseSettings],
secret_id: str,
env_prefix: str | None = None,
env_parse_none_str: str | None = None,
env_parse_enums: bool | None = None,
) -> None:

    ... 

    super().__init__(
        settings_cls,
        case_sensitive=True,
        env_prefix=env_prefix,
        env_nested_delimiter='--',
        env_ignore_empty=False,
        env_parse_none_str=env_parse_none_str,
        env_parse_enums=env_parse_enums,
    )

Comment on lines +1 to +3
from __future__ import (
annotations as _annotations,
) # important for BaseSettings import to work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated. please revert this and the other ones

@hramezani
Copy link
Member

Thanks @femiadebayo for this PR. Please revert unrelated formatting changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants