-
-
Notifications
You must be signed in to change notification settings - Fork 91
feat: Add cli_shortcuts
to CLI settings
#624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ab6752c
to
4eb7dd5
Compare
@maxnoe Please verify if it is okay |
@kschwab do you have time to take a look here? |
Thanks for the quick implementation, I played around with the branch here and it works as I would expect! Can't comment too much about the code itself. |
4eb7dd5
to
9abab16
Compare
please review |
I am waiting for @kschwab for a review, as he implemented most of the CLI settings source code. |
Thanks @karta9821 and @maxnoe for the PR. I am back from vacation. The only two items I see are:
The only real concern I have is confusion between Other than those items, everything else looks good. |
Thanks @kschwab for checking the PR
Agree, Do you have a suggestion for the config name? @karta9821 Please address the points mentioned by @kschwab. Then we can merge the PR. |
Sure, I can adjust the code :) How about |
Looks good to me. what do you think @kschwab |
@hramezani @karta9821 yes, |
9abab16
to
2c4d97f
Compare
cli_aliases
to CLI settingscli_shortcuts
to CLI settings
e2d1608
to
5a53e0b
Compare
Fixed |
`cli_shortcuts` is a mapping of field target to field aliases.
5a53e0b
to
485a0fb
Compare
@karta9821 Thanks for the update. please add the documentation for it |
PR Change SummaryAdded support for CLI shortcuts in settings configuration, allowing users to define alternative argument names for command-line interface options.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
82ddf29
to
84eda6d
Compare
84eda6d
to
f9c116c
Compare
Added |
Thanks @karta9821 for the quick update. @kschwab please take a final look when you have time. |
Hey @karta9821 thanks for the changes! It's a great addition, looks good to me. |
Thanks all |
It addresses to #623
Selected Reviewer: @dmontagu