optimizations in URL implementation #1833
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1833 will not alter performanceComparing Summary
|
Viicos
reviewed
Oct 13, 2025
| } else { | ||
| Cow::Owned(encoded) | ||
| } | ||
| fn encode_userinfo_component(value: &str) -> impl fmt::Display + use<'_> { |
There was a problem hiding this comment.
Seems like the use<..> syntax is only available in Rust 2024.
There was a problem hiding this comment.
Yep we need MSRV 1.82.
There is debate in PyO3 to increase MSRV to 1.83 PyO3/pyo3#5486, so let's just wait on this until 2.13 perhaps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Generally reduces use of needless
.to_string()calls around the URL code, to avoid temporary strings. Done as a follow up to #1829Related issue number
N/A
Checklist
pydantic-core(except for expected changes)