Skip to content
This repository was archived by the owner on Apr 11, 2026. It is now read-only.

bump inline snapshot, re-enable for freethreaded tests#1665

Closed
davidhewitt wants to merge 1 commit intomainfrom
dh/free-threaded-snapshot
Closed

bump inline snapshot, re-enable for freethreaded tests#1665
davidhewitt wants to merge 1 commit intomainfrom
dh/free-threaded-snapshot

Conversation

@davidhewitt
Copy link
Copy Markdown
Collaborator

Change Summary

inline-snapshot 0.20.3 made black formatting thread-safe, let's see if this allows us to re-enable...

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 7, 2025

CodSpeed Performance Report

Merging #1665 will improve performances by 38.12%

Comparing dh/free-threaded-snapshot (01c3338) with main (d8be765)

Summary

⚡ 1 improvements
✅ 156 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_strict_union_error_core 45.1 µs 32.7 µs +38.12%

@davidhewitt
Copy link
Copy Markdown
Collaborator Author

Will close this as it looks like inline-snapshot is still not thread-safe. Can resume once upstream is fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant