begin refactoring ValLineError collection
#1517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
CodSpeed Performance ReportMerging #1517 will not alter performanceComparing Summary
|
|
Will close for now, I might come back to this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Motivated by #1512.
Our error handling code is getting complicated at each callsite. This begins an attempt to refactor it to move repetition into common code, by adding a
.collect_line_errors()helper to takeLineErrorsand collect them up.This only touches a few of the many code paths which collect line errors; they have a variety of different ways to build up locations. If we think we want to proceed with this, I'll follow up with further refactorings another day.
Related issue number
N/A
Checklist
pydantic-core(except for expected changes)