Support MCP sampling #1884
Merged
Support MCP sampling #1884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
samuelcolvin
force-pushed
the
mcp-sampling
branch
from
37a911e to
f916e0b
Compare
DouweM
reviewed
Jun 17, 2025
| if isinstance(content, mcp_types.TextContent): | ||
| user_part_content: str | Sequence[messages.UserContent] = content.text | ||
| else: | ||
| # image content |
There was a problem hiding this comment.
Should we use pydantic_ai.mcp._map_tool_result_part here, to cover all types of content?
There was a problem hiding this comment.
Some type incompatibilities, let's do this later
Kludex
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both client and server.
To visualize, needs pydantic/logfire#1103.