Show invalid message for select fields #360
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #270
It can be useful to display invalid messages for select fields when their validation depends on another field.
Before:
![Screenshot 2024-10-17 at 15 23 44](https://private-user-images.githubusercontent.com/145333509/377483942-57eecf26-c58f-468d-a65b-16e24554c5d8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NTEwOTIsIm5iZiI6MTczOTQ1MDc5MiwicGF0aCI6Ii8xNDUzMzM1MDkvMzc3NDgzOTQyLTU3ZWVjZjI2LWM1OGYtNDY4ZC1hNjViLTE2ZTI0NTU0YzVkOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxMjQ2MzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZWIwNWU3MDI2MmJjMGFiNTlkYzJhZDI4MWVhNjhkOTcyOWY2ZjZiMzZiYTUyNzg2MzE1NDVlM2EyNDc2OGM3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.iwYU7JNbQXgNuGDDRZG29Vo_28ntYcMQ88mSrVML_uw)
After:
![Screenshot 2024-10-17 at 15 11 29](https://private-user-images.githubusercontent.com/145333509/377481079-8f2f5f3e-638f-447b-8bfe-e8fde20f46ae.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NTEwOTIsIm5iZiI6MTczOTQ1MDc5MiwicGF0aCI6Ii8xNDUzMzM1MDkvMzc3NDgxMDc5LThmMmY1ZjNlLTYzOGYtNDQ3Yi04YmZlLWU4ZmRlMjBmNDZhZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxMjQ2MzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05OTE5ZGZmOThhMTA0YjEzZWQ1ZjVjNWRmZDc0NzA5ZTFjN2M3ZDAzNGU1NDBkZmEzNmEwMTZmYjVmMmVmMzllJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9._ys7iAQ2-4LR9LhMK0loXgvXtTDC8JgvDAWqA53Aa6c)
For this error 422:
We could go further and display the border in red like the text field, but that doesn't seem trivial.