Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add empty json from default dictionary to GET payloads to avoid 403 from jira API. #2322

Conversation

bmcalary-atlassian
Copy link
Contributor

Proposal to resolve #1945

I am an engineer for Atlassian, but this is a 3rd party library not directly maintained by us. We have submitted a PR here out of good will to the community. But I nor anyone I know here at Atlassian have the ability to label, approve or merge this PR.

This library is owned by pycontribs https://github.com/pycontribs . I have emailed them here [email protected]

We can also try to mention others who have contributed, such as @studioj @adehad @ssbarnea .

@bmcalary-atlassian
Copy link
Contributor Author

@kanak-kabara you could try doing a pip install of the proposed fix like so

pip install git+https://github.com/bmcalary-atlassian/jira.git@Dont-add-empty-json-from-default-dictionary-to-GET-payloads-to-avoid-403-from-jira-API

Or you could try cloning the main branch from the official project to disk, and patching it locally before doing a pip install.

I was able to successfully install the project and use it in a python script.

@kanak-kabara
Copy link

@bmcalary-atlassian The pip install worked, and the fix looks good! Thanks a ton for the suggestion. We will keep things pinned until this is merged.

@studioj
Copy link
Collaborator

studioj commented Apr 1, 2025

@bmcalary-atlassian could you rebase after the fixes from @ssbarnea and @skumar36-atlassian ? thank you
Edit: seems I can... Lets try

@studioj studioj force-pushed the Dont-add-empty-json-from-default-dictionary-to-GET-payloads-to-avoid-403-from-jira-API branch from f7ff3a6 to 388c0c6 Compare April 1, 2025 19:32
@dbaxa dbaxa merged commit 7676b47 into pycontribs:main Apr 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMMEDIATE - Jira blocking GET requests with body payload
4 participants