Add a test with classes #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalalium
requested changes
Apr 30, 2025
benchmarks/tests/splines.py
Outdated
| def _find_span(self, x: float) -> int: | ||
| # Knot index at left/right boundary | ||
| low = self.degree | ||
| high = 0 |
There was a problem hiding this comment.
I think this line is superfluous
benchmarks/tests/numba_splines.py
Outdated
| def _find_span(self, x: float) -> int: | ||
| # Knot index at left/right boundary | ||
| low = self.degree | ||
| high = 0 |
There was a problem hiding this comment.
I think this line is superfluous
yguclu
requested changes
May 2, 2025
Comment on lines
+133
to
+134
| 'import numpy as np; s = Spline(5, knots = np.linspace(0,1, 1000), coeffs = np.ones(1000)); x = np.random.rand(100000); y = np.empty(100000);', | ||
| 's.eval(x, y)'), |
There was a problem hiding this comment.
I would put the actual test in a separate function which takes the test parameters, as we have done in all the other cases.
There was a problem hiding this comment.
I wanted to avoid the linspace being measured in the times. Should I:
- not care about this?
- Add a function returning
s,xandywhich can be called in the setup stage? - leave as is?
benchmarks/tests/numba_splines.py
Outdated
Comment on lines
53
to
56
| y[i] += self._coeffs[span-self.degree+j]*basis[j] | ||
|
|
||
|
|
||
| def _find_span(self, x: float) -> int: |
There was a problem hiding this comment.
Too many empty lines, there should only be one here.
benchmarks/tests/splines.py
Outdated
Comment on lines
46
to
49
| y[i] += self._coeffs[span-self.degree+j]*basis[j] | ||
|
|
||
|
|
||
| def _find_span(self, x: float) -> int: |
There was a problem hiding this comment.
Too many empty lines, there should only be one here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.