collect eq result for each step#33
Closed
HUISUN24 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
I think this is a good idea, but I would like to see it implemented differently. I would suggest either
Also if you could make sure the tests pass and include an example of using this new addition to make a new plot or something, that'd be fantastic! |
Contributor
|
With the Workspace API, I think it might be more useful to store the global conditions, chemical potentials and composition sets at each step, then we should be able to extract any properties that satisfies the ComputableProperty protocol. |
Merged
Collaborator
|
Superseded by #39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Brandon,
I added new functions into scheil to collect the eq results for each step. In that way, the results will be used to calculate the compositions and site fraction of each solid phase.