Add methods related to client hello callback #1456
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schwabe
force-pushed
the
add_client_hello_callback
branch
2 times, most recently
from
ce6d7bd to
370aa28
Compare
These methods allow a server to switch the context when looking at ALPN and servername together. This is for example require when implementing the ACME tls-alpn/1 protocol. Unfortunately, OpenSSL does not provide any utility function to actually parse ClientHello extensions when using these APIs and the user has to write their own methods. Closes: pyca#1430 Signed-off-by: Arne Schwabe <[email protected]>
schwabe
force-pushed
the
add_client_hello_callback
branch
from
370aa28 to
705d7cf
Compare
|
Coverage test seem to fail since the newly added methods are not tested without having the newer cyrptography version with the added functions too. |
|
Hmm, we should probably adapt the coverage bits to merge from multiple jobs (as we do on cryptography). @mhils do you have an opinion on this API? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods allow a server to switch the context when looking at ALPN and servername together. This is for example require when implementing the ACME tls-alpn/1 protocol.
Unfortunately, OpenSSL does not provide any utility function to actually parse ClientHello extensions when using these APIs and the user has to write their own methods.
Closes: 1430
This PR depends on pyca/cryptography#13634 but I am not sure how to express that properly in the build files.