Skip to content

Fixed hover background color issue #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

hfactor13
Copy link
Contributor

I fixed the hover background issue for the Translation Guide for the Python Packaging Guide (Issue #532). I also ran the nox docs-test command, and everything came back successful. Feel free to let me know if there's anything else I should include with this pull request.

@hfactor13
Copy link
Contributor Author

I just realized that in the dark mode, the hover text looks a little bit hard to read, so I might edit that as well so that it is consistent across both light and dark modes.

@tkoyama010 tkoyama010 requested a review from Copilot July 12, 2025 19:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the hover background color issue in the Translation Guide’s interactive graph by explicitly setting hover label styling.

  • Added hoverlabel_bgcolor to ensure hover labels have a visible background.
  • Added hoverlabel_font_color to guarantee hover text is readable.
  • Verified that no docs tests were broken by running nox docs-test.

hfactor13 and others added 3 commits July 12, 2025 14:49
Removed extra white space.

Co-authored-by: Copilot <[email protected]>
Used CSS variable instead of hardcoded "white" value.

Co-authored-by: Copilot <[email protected]>
@lwasser
Copy link
Member

lwasser commented Jul 12, 2025

@all-contributors please add @hfactor13 for code, review

Copy link
Contributor

@lwasser

I've put up a pull request to add @hfactor13! 🎉

@hfactor13
Copy link
Contributor Author

hfactor13 commented Jul 16, 2025

I noticed that when I rebuilt the website, my light mode changes didn't show up. I rechecked the CSS variable --bs-body-bg, and it should be showing a white background for both light and dark modes. I remember I was able to get it to work in the sprints, but now it seems that I am back to square one it seems.

@sneakers-the-rat
Copy link
Contributor

I am at keyboard again and can help with this, but the PR looks empty to me?

@sneakers-the-rat
Copy link
Contributor

@hfactor13 i think something broke about this PR because i'm not seeing a diff, but i made a version over here: #556

sorry for the confusion. as far as i'm aware there is no way to use css vars in the plotly color declarations in some places, and these happen to be some of those places.

@hfactor13
Copy link
Contributor Author

hfactor13 commented Jul 18, 2025

@sneakers-the-rat I see what you mean. Yes, it's weird that the diff didn't show in this PR. I saw your linked PR. I was planning to go in that direction where I would change the CSS directly, but I didn't know the name of the CSS tag. It's a bummer that I can't just change these properties from Plotly directly, but hey, at least I learned something new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants