Fix issues in update-language nox session caused by translation stats #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwasser
approved these changes
Jul 12, 2025
|
Thank you for this, @flpm !! let's merge. Looking at this pr I also noticed that the format of the nox file was cleaned up in this pr. Should we setup pre-commit.ci to handle nox file formatting? OR should we add a .editorconfig file to the repo and help people set that up so the noxfile formatting remains consistent? this can be a new issue and is lower priority I just noticed it here. it's an easy cleanup step :) |
|
I wondered if my config for linting was not being too opinionated :) it might very well be my fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update we merged recently to update the translation stats (#521) introduced a bug that caused the update translation sessions to fail because it assumes the build directory is /html when looking for the JSON file, but when running the gettext sphinx builder that is not true. I added a check to only compute stats when using the html builder.
I also cleaned up some old code that was at the end of the update language session function that was causing the session to fail but it was no longer needed.