Migrate project metadata from setup.py to pyproject.toml (PEP 639 Compliance) #1615

RaphaelFLT · 2025-10-13T15:17:10Z

Hello,

This Pull Request addresses the maintenance task of migrating project configuration to the modern, standardized format.

Key Changes:

Migrate Metadata: All project metadata (description, maintainers, dependencies, etc.) is moved from the legacy setup.py/setup.cfg to the [project] table in pyproject.toml.
Build System Standard: Adopted the modern PEP 517/PEP 621 build backend (via setuptools.build_meta), which resolves the deprecation warning noted in the CI pipeline (as discussed in Updating Project Metadata to PEP 639 #1613 ).
PEP 639 Compliance: Updated the license field to use the file = "LICENSE" approach, ensuring full compliance with PEP 639 for license specification.
Integrate Tools: Configuration for pytest (including pytest-cov), black, isort, and flake8 has been consolidated under the [tool.*] tables in pyproject.toml.

Testing & Validation:

All original project information has been preserved in the new pyproject.toml.
The entire test suite (pytest) runs successfully with this configuration locally (including coverage, text shaping, and encryption tests).

This change ensures the project remains compatible with upcoming Python tooling changes and future versions of pip.

Thank you for the review!

merge de la version a jour @

fpdf/fpdf.py

fpdf/__init__.py

pyproject.toml

Co-authored-by: Lucas Cimon <[email protected]>

Merge branch 'master' of https://github.com/RaphaelFLT/fpdf2-ADSILLH Merge latest changes from the remote 'master' branch into local branch to resolve divergence before pushing final review fixes.

fpdf/fpdf.py

…ion__ after FPDF_VERSION

Lucas-C · 2025-10-15T09:20:28Z

A couple of notes:

we do not currently use flake8, even if its' mentioned in setup.cfg. I'd vote to get rid of this entry, as we are already using black
we do not currently use isort. While I'm open to discussion, I'm not sure that's a tool that we really need. It may be better to introduce it in a separate PR, and also ensure that it's checked in CI pipelines if we adopt it

Lucas-C · 2025-10-15T09:23:33Z

pyproject.toml

+
+authors = [
+  { name = "Olivier PLATHEY" },
+  { name = "Max" }


Suggested change

{ name = "Max" }

{ name = "Max" }

{name = "Lucas Cimon (@Lucas-C)"

Given that I maintain & contribute to fpdf2 since 2020, I would also like to be mention there please 🙂

Maybe @andersonhc & @alexanderankin would like to be mentioned too

My username would only be for historical preservation. I had found the library from Mariano Reingart and together with Lucas restored publishing and maintenance after long period of no maintenance. btw I maintain testcontainers-python now on a minimal basis and we use poetry (and thus pyproject.toml) with release-please.

Lucas-C · 2025-10-15T09:24:17Z

pyproject.toml

+]
+
+maintainers = [
+  { name = "Lucas Cimon" }


Suggested change

{ name = "Lucas Cimon" }

{ name = "Lucas Cimon" }

{ name = " Anderson Herzogenrath da Costa (@andersonhc)"

Lucas-C · 2025-10-15T09:26:38Z

pyproject.toml

+
+dependencies = [
+  "defusedxml",
+  "Pillow>=8.0.0,!=9.2.*",


Suggested change

"Pillow>=8.0.0,!=9.2.*",

"Pillow>=8.0.0,!=9.2.*", # minimum version tested in .github/workflows/continuous-integration-workflow.yml

# Version 9.2.0 is excluded due to DoS vulnerability with TIFF images: https://github.com/py-pdf/fpdf2/issues/628

# Version exclusion explained here: https://devpress.csdn.net/python/630462c0c67703293080c302.html

Please preserve explanatory comments from setup.cfg 🙂

Lucas-C · 2025-10-15T09:28:01Z

pyproject.toml

+exclude = '''
+/(
+    \.git
+  | \.hg
+  | \.mypy_cache
+  | \.tox
+  | \.venv
+  | _build
+  | buck-out
+  | build
+  | dist
+)/
+'''


Is this necessery given that we already have a .gitignore?

Lucas-C · 2025-10-15T09:28:15Z

pyproject.toml

+line-length = 88
+target-version = ["py39", "py310", "py311", "py312"]
+skip-string-normalization = false


Why introducing those settings?

Lucas-C · 2025-10-15T09:34:40Z

pyproject.toml

+dynamic = ["version"]
+description = "Simple & fast PDF generation for Python"
+readme = "README.md"
+requires-python = ">=3.9"


Suggested change

requires-python = ">=3.9"

requires-python = ">=3.10"

Since I have just merged #1620

Lucas-C · 2025-10-15T09:34:50Z

pyproject.toml

+  "Intended Audience :: Developers",
+  "License :: OSI Approved :: GNU Lesser General Public License v3 (LGPLv3)",
+  "Programming Language :: Python",
+  "Programming Language :: Python :: 3.9",


Suggested change

"Programming Language :: Python :: 3.9",

Since I have just merged #1620

Lucas-C · 2025-10-15T11:13:28Z

pyproject.toml

+  { name = "Lucas Cimon" }
+]
+
+keywords = ["pdf", "unicode", "png", "jpg", "ttf", "barcode"]


Suggested change

keywords = ["pdf", "unicode", "png", "jpg", "ttf", "barcode"]

keywords = ["pdf", "unicode", "png", "jpg", "ttf", "barcode", "library", "markdown"]

I had a look at the top 100 most used Pypi keywords: https://chezsoi.org/shaarli/shaare/ZNiBqA

library & markdown seem like good additions 🙂

andersonhc · 2025-10-15T12:08:23Z

pyproject.toml

+]
+
+[tool.setuptools.dynamic]
+version = { attr = "fpdf.FPDF_VERSION" }


Suggested change

version = { attr = "fpdf.FPDF_VERSION" }

version = { attr = "fpdf.fpdf:FPDF_VERSION" }

For the record, we have documented usages of from fpdf import FPDF_VERSION for a long time.
Example: https://github.com/py-pdf/fpdf2/blob/master/tutorial/tuto7.py#L4

So I'm not sure why/if this fix is needed?

When we tried to build this PR it failed trying to import fpdf to get the version
https://github.com/py-pdf/fpdf2/actions/runs/18476680763

To import the main module to get the version number failed because fonttools was not available yet in the build environment

I believe we need this change so ast can get the string without a full import

Alright, I understand now, thanks 👍 🙂

Lucas-C · 2025-10-15T14:50:39Z

@RaphaelFLT no hurry for reviewing our comments, take your time 🙂

Are you contributing as part of Hacktoberfest?

RaphaelFLT · 2025-10-15T16:34:18Z

@RaphaelFLT no hurry for reviewing our comments, take your time 🙂

Are you contributing as part of Hacktoberfest?

No, actually I'm doing it for my studies, we have to contribute to an open source project. I found this project interesting, so I'm trying to contribute to it. I'm very new to GitHub and not a great developer either, but you have to start somewhere.

Lucas-C · 2025-10-16T11:24:28Z

No, actually I'm doing it for my studies, we have to contribute to an open source project. I found this project interesting, so I'm trying to contribute to it. I'm very new to GitHub and not a great developer either, but you have to start somewhere.

You are very welcome.
Thank you for your time and interest in fpdf2.

Good luck with your studies.
Comme on dit en français : "merde" 🙂

Lucas-C · 2025-10-17T10:20:19Z

I think we could publish a new version of fpdf2 once this is merged 🙂
We have quite a few new features & bugfixes pending release: https://github.com/py-pdf/fpdf2/blob/master/CHANGELOG.md

Lucas-C · 2025-10-27T07:30:32Z

Hi 🙂 👋
We are close to the end of the month, I was just curious to know if you were willing to finish this PR as part of Hacktoberfest?

RaphaelFLT · 2025-10-28T10:31:01Z

Hi 🙂 👋 We are close to the end of the month, I was just curious to know if you were willing to finish this PR as part of Hacktoberfest?

Hi, sorry for the delay; I've been quite busy for the last few weeks.

I have now made the changes you requested. I ran the pytest locally and got the following results:

========================== short test summary info ===========================
FAILED test/signing/test_sign.py::test_sign_pkcs12 - OSError: endesive.signer not available - PDF cannot be signed - Try: pip install endesive
FAILED test/signing/test_sign.py::test_sign_pkcs12_with_link - OSError: endesive.signer not available - PDF cannot be signed - Try: pip install endesive
================= 2 failed, 1599 passed, 2 skipped, 2 xfailed, 9 warnings in 146.72s =================

Even though I've confirmed that endesive is installed, these two tests still fail. Is this a known issue, or is it likely a problem on my end? ( I'm on MacOs)

Thanks for your patience! :)

andersonhc · 2025-10-28T12:24:07Z

Even though I've confirmed that endesive is installed, these two tests still fail. Is this a known issue, or is it likely a problem on my end? ( I'm on MacOs)

try pip install endesive[full]
or from the root of the library pip install -r test\requirements.txt - it includes endesive[full] and all other dependencies for the test suite.

FRELAUT added 3 commits October 7, 2025 12:08

migration du projet pour l'utilisation de pyproject.toml

6b060c1

Merge remote-tracking branch 'upstream/master'

fdb342b

merge de la version a jour @

Correction License to the right format

0aae98a

andersonhc requested changes Oct 13, 2025

View reviewed changes

fpdf/fpdf.py Outdated Show resolved Hide resolved

fpdf/__init__.py Outdated Show resolved Hide resolved

Lucas-C reviewed Oct 13, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

RaphaelFLT and others added 3 commits October 13, 2025 21:10

Update pyproject.toml

d98b132

Co-authored-by: Lucas Cimon <[email protected]>

fix: Resolve maintainer review comments regarding version variables.

36c3dc1

Merge branch 'master' of https://github.com/RaphaelFLT/fpdf2-ADSILLH

f7aa980

Merge branch 'master' of https://github.com/RaphaelFLT/fpdf2-ADSILLH Merge latest changes from the remote 'master' branch into local branch to resolve divergence before pushing final review fixes.

andersonhc reviewed Oct 13, 2025

View reviewed changes

fpdf/fpdf.py Outdated Show resolved Hide resolved

FRELAUT and others added 3 commits October 13, 2025 21:51

fix:small correction in fpdf.py requested during review, moved __vers…

16e5eda

…ion__ after FPDF_VERSION

fix : addded fonttools

0226333

Merge branch 'master' into master

c1e6886

Lucas-C reviewed Oct 15, 2025

View reviewed changes

andersonhc reviewed Oct 15, 2025

View reviewed changes

FRELAUT added 2 commits October 28, 2025 11:20

fix: Resolve merge conflict by removing setup.cfg

6b856b6

Merge branch 'master' of https://github.com/RaphaelFLT/fpdf2-ADSILLH

a063a63

	{ name = "Max" }
	{ name = "Max" }
	{name = "Lucas Cimon (@Lucas-C)"

	{ name = "Lucas Cimon" }
	{ name = "Lucas Cimon" }
	{ name = " Anderson Herzogenrath da Costa (@andersonhc)"

-  "Pillow>=8.0.0,!=9.2.*",
+  "Pillow>=8.0.0,!=9.2.*",    # minimum version tested in .github/workflows/continuous-integration-workflow.yml
+  # Version 9.2.0 is excluded due to DoS vulnerability with TIFF images: https://github.com/py-pdf/fpdf2/issues/628
+  # Version exclusion explained here: https://devpress.csdn.net/python/630462c0c67703293080c302.html

	keywords = ["pdf", "unicode", "png", "jpg", "ttf", "barcode"]
	keywords = ["pdf", "unicode", "png", "jpg", "ttf", "barcode", "library", "markdown"]

	version = { attr = "fpdf.FPDF_VERSION" }
	version = { attr = "fpdf.fpdf:FPDF_VERSION" }

Uh oh!

Migrate project metadata from setup.py to pyproject.toml (PEP 639 Compliance) #1615

Are you sure you want to change the base?

Migrate project metadata from setup.py to pyproject.toml (PEP 639 Compliance) #1615

Uh oh!

Conversation

RaphaelFLT commented Oct 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lucas-C commented Oct 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lucas-C Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lucas-C Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lucas-C commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RaphaelFLT commented Oct 15, 2025

Uh oh!

Lucas-C commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lucas-C commented Oct 17, 2025

Uh oh!

Lucas-C commented Oct 27, 2025

Uh oh!

RaphaelFLT commented Oct 28, 2025

Uh oh!

andersonhc commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Lucas-C Oct 15, 2025 •

edited

Loading

Lucas-C Oct 15, 2025 •

edited

Loading

Lucas-C commented Oct 15, 2025 •

edited

Loading

Lucas-C commented Oct 16, 2025 •

edited

Loading