fix: update envs recursively for subclasses

pipen/utils.py

@@ -212,6 +212,13 @@ def update_dict(
     Args:
         parent: The parent dictionary
         new: The new dictionary
+        depth: The depth to be copied.
+
+    Examples:
+        >>> parent = {"a": {"b": 1}}
+        >>> new = {"a": {"c": 2}}
+        >>> update_dict(parent, new)
+        >>> # {"a": {"b": 1, "c": 2}}
 
     Returns:
         The updated dictionary or None if both parent and new are None.
@@ -220,7 +227,16 @@ def update_dict(
         return None
 
     out = (parent or {}).copy()
-    out.update(new or {})
+    for key, val in (new or {}).items():
+        if (
+            key not in out
+            or not isinstance(val, dict)
+            or not isinstance(out[key], dict)
+        ):
+            out[key] = val
+        else:
+            out[key] = update_dict(out[key], val)
+
     return out
 
 

tests/test_proc.py

@@ -154,3 +154,13 @@ def test_script_file_exists(pipen):
 def test_invalid_name():
     with pytest.raises(PipenOrProcNameError):
         Proc.from_proc(SimpleProc, name="a b")
+
+
+def test_inherit_proc_envs():
+    class Proc1(Proc):
+        envs = {"a": {"b": 1, "c": 2}}
+
+    class Proc2(Proc1):
+        envs = {"a": {"b": 2}}
+
+    assert Proc2.envs == {"a": {"b": 2, "c": 2}}

tests/test_utils.py

@@ -75,6 +75,11 @@ def test_update_dict():
     assert update_dict(None, None) is None
     assert update_dict({}, None) == {}
     assert update_dict(None, {}) == {}
+    assert update_dict({"a": 1}, {"b": 2}) == {"a": 1, "b": 2}
+    assert update_dict({"a": 1}, {"a": 2}) == {"a": 2}
+    assert update_dict({"a": {"b": 1}}, {"a": {"c": 2}}) == {
+        "a": {"b": 1, "c": 2}
+    }
 
 
 def test_strsplit():