Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert About button to a Menu Bar entry #2351

Closed
wants to merge 2 commits into from

Conversation

MattHag
Copy link
Collaborator

@MattHag MattHag commented Mar 1, 2024

@pfps
Copy link
Collaborator

pfps commented Mar 1, 2024

Where is this menu entry supposed to show up? When I run this PR I don't see any way to get to it.

I also see the following messages at startup:

idefix Solaar> bin/solaar -ddd
2024-03-01 09:47:06,515,515     INFO [MainThread] solaar.gtk: version 1.1.11-58-ge866fdbc, language en_US (UTF-8)
2024-03-01 09:47:06,520,520    DEBUG [MainThread] hidapi.udev: Starting dbus monitoring

(solaar:154002): Gtk-CRITICAL **: 09:47:06.521: gtk_application_set_app_menu: assertion 'g_application_get_is_registered (G_APPLICATION (application))' failed
2024-03-01 09:47:06,550,550    DEBUG [MainThread] solaar.ui: startup registered=True, remote=False
2024-03-01 09:47:06,551,551    DEBUG [AsyncUI] solaar.tasks: started

@MattHag
Copy link
Collaborator Author

MattHag commented Mar 1, 2024

On Mac it shows up as supposed in the OS native menu bar, where File, Edit, Help etc. Is commonly placed. On Linux it might need a different Menu call.

@pfps
Copy link
Collaborator

pfps commented Mar 1, 2024

Some Linux window managers don't have this interface, I think. Any solution will have to work for them.

@MattHag
Copy link
Collaborator Author

MattHag commented Mar 2, 2024

Windows too and I don't want to introduce a menu row now. I drop that for now.

@MattHag MattHag closed this Mar 2, 2024
@MattHag MattHag deleted the gtk_menu_bar_about_2349 branch October 2, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants