-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Batzelis 2017 simple nonlinear PV model #2563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR currently adds three new functions. As they are related to each other I thought it would be helpful to review them together, but I can split the PR into smaller pieces to make it more digestible if needed. To summarize the three functions:
The third, effectively, combines the first two with Questions for reviewers:
|
cwhanse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some reactions.
|
A question about the method: does |
Close but not exactly the same, in my testing. The latter has to be |
I think this is the right decision for pvlib because of precedent, although personally I much prefer the normalized values.
+1
+1 |
| def batzelis(photocurrent, saturation_current, resistance_series, | ||
| resistance_shunt, nNsVth): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kandersolar Was adding this SDE solver to the method options in pvsystem.singlediode discussed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we discussed it. I'm not in favor of adding it as a method option to pvsystem.singlediode because singlediode.batzelis solves an approximation of the single diode equation, rather than the SDE itself.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.