Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples of shaded_fraction1d #2215

Merged

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented Sep 19, 2024

  • Solves issue raised at mailing list: https://groups.google.com/g/pvlib-python/c/Yl5tL3HKtMU
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

I forgot to update the outputs after doing changes to the inputs...
th-2293064154

Docs link: https://pvlib-python--2215.org.readthedocs.build/en/2215/reference/generated/pvlib.shading.shaded_fraction1d.html

Do you think we need an whatsnew entry for this?

@echedey-ls echedey-ls marked this pull request as ready for review September 19, 2024 21:23
@kandersolar kandersolar added this to the v0.11.1 milestone Sep 23, 2024
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @echedey-ls! I think a brief whatsnew entry is appropriate.

@kandersolar kandersolar mentioned this pull request Sep 23, 2024
11 tasks
@echedey-ls echedey-ls changed the title Update examples of shaded_fraction1d Fix examples of shaded_fraction1d Sep 23, 2024
@echedey-ls
Copy link
Contributor Author

Done!

@kandersolar kandersolar merged commit d8ea82b into pvlib:main Sep 23, 2024
30 checks passed
@kandersolar
Copy link
Member

Thanks @echedey-ls!

@echedey-ls echedey-ls deleted the shaded_fraction1d_examples_addendum branch September 23, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants