-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Convert between CEC and PVsyst single diode models #2212
base: main
Are you sure you want to change the base?
Conversation
15, 25, 50, 75, 15, 25, 50, 75, 15, 25, 50, 75]]).T, | ||
dtype=np.float64) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess one might discuss whether you are converting models or sets of parameters. |
Test failure for |
@adriesse , do you have any proposal in mind? For example,
scipy=1.7.0 is the first version to support it, and is also supported in Py3.9 (taking into account upcoming drop of Py3.8 support). I would edit this requirement for future >=Py3.9 release (#2213). Source of scipy docs on nelder-mead; scipy 1.6.3 bumps to 1.7.0: |
Is the simplex solver required? Why not try Powell instead? |
docs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Primary reference is in review. Feedback on function naming and signature is welcome.