Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear shade loss model - continuation of pr 1725 #2004

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented Apr 5, 2024

Addresses the linear thin film module losses.

Comment from @kandersolar at #1962:

you are saying that we need a substantive reference that says linear power loss models are valid for thin film modules. Is that right?

What I'd really like to reference is a paper that deals with specifically the equation implemented in this PR: power_loss_fraction = shaded_fraction1d * (1 - diffuse_fraction).

@mikofski do you have a reference for that or should I change to irradiance losses and a SAM reference?

Wait for #1962 to be merged before this one so the docstring makes sense.

@mikofski
Copy link
Member

mikofski commented Apr 6, 2024

I found this by googling:
https://energy.sandia.gov/wp-content/gallery/uploads/26-Littmann-Tracking-and-Diffuse-Shading.pdf0_.pdf

It’s for series 4 but explains why linear shade for orientation perpendicular to cells

@echedey-ls
Copy link
Contributor Author

I found this by googling:
https://energy.sandia.gov/wp-content/gallery/uploads/26-Littmann-Tracking-and-Diffuse-Shading.pdf0_.pdf
It’s for series 4 but explains why linear shade for orientation perpendicular to cells

I don't really get to see where it explains the shade is perpendicular to the cells. I mean, I see the statement but not the reasoning.

I would prefer some other reference, although I'll stick to that one. I will update the PR by the end of the week.

@mikofski
Copy link
Member

mikofski commented Apr 11, 2024

Maybe if you combine this reference with the FirstSolar series 4 user guide. The point is the cells are long and thin and strung in series from side to side. The user guide explains that they should only be oriented so that the cells extend from bottom to top, not left to right or damage will occur. There is also a series 6/7 user guide.

@echedey-ls
Copy link
Contributor Author

Thanks for that insightful manual. I like how the docstring is turning out!

These references don't have the model equation nor address what the model modifies (power yield or irradiance). I think it doesn't matter as long as we find some other source that deals with the model eventually. Maybe some code snippet on the public domain under First Solar authorship?

pvlib/shading.py Outdated Show resolved Hide resolved
pvlib/shading.py Outdated Show resolved Hide resolved
pvlib/shading.py Outdated Show resolved Hide resolved
pvlib/shading.py Outdated Show resolved Hide resolved
pvlib/shading.py Outdated Show resolved Hide resolved
pvlib/shading.py Outdated Show resolved Hide resolved
@echedey-ls
Copy link
Contributor Author

echedey-ls commented Jun 14, 2024

I have the feeling that the reference still is an issue. If you maintainers think so, do you think the same reference as #2063 and #2070 , equation (3), is a sustainable reference?

https://www.sciencedirect.com/science/article/abs/pii/S092702481000454X

Pro: it compares the results in Table 2 and Fig. 4.
Cons: it is compared for non-monolithic modules

EDIT: content
image

@mikofski
Copy link
Member

mikofski commented Jun 22, 2024

Hi @echedey-ls that reference isn’t really valid for firstsolar modules because firstsolar don’t use bypass diodes and the power loss isn’t exactly the same as the fraction of direct beam shaded, because there is still diffuse sky and ground. I think the best references are Kevin’s & Adam’s paper and the poster from PVPMC 2023 (https://pvpmc.sandia.gov/download/5381/?tmstv=1719027091). Saying the loss is linear is just industry jargon four saying there is no electrical mismatch due to shade, so the only loss is the linear decrease in direct beam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add linear shade loss model for thin film
3 participants