-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to fit Huld model #1979
base: main
Are you sure you want to change the base?
Conversation
Test failures are unrelated. Coverage decrease is related to importing statsmodels. I think I have addressed the maintainer's comments and concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We have one thing that is not fully resolved:
I would suggest this PR join the queue, and perhaps more discussion will ensue. The upcoming PVPMC is also a great opportunity to discuss and perhaps develop a policy. |
Has anyone tried contacting Thomas Huld or any of the other authors to ask what fitting method was used? |
I have reached out to several of the authors and have gotten no response. |
[ ] Closes #xxxxdocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.