Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to fit Huld model #1979

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add method to fit Huld model #1979

wants to merge 18 commits into from

Conversation

cwhanse
Copy link
Member

@cwhanse cwhanse commented Feb 23, 2024

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@cwhanse cwhanse added this to the v0.10.4 milestone Feb 23, 2024
pvlib/pvarray.py Outdated Show resolved Hide resolved
pvlib/pvarray.py Outdated Show resolved Hide resolved
pvlib/pvarray.py Show resolved Hide resolved
pvlib/pvarray.py Outdated Show resolved Hide resolved
pvlib/pvarray.py Show resolved Hide resolved
pvlib/pvarray.py Outdated Show resolved Hide resolved
@kandersolar kandersolar modified the milestones: v0.10.4, v0.10.5 Mar 18, 2024
@cwhanse
Copy link
Member Author

cwhanse commented Apr 4, 2024

Test failures are unrelated. Coverage decrease is related to importing statsmodels.

I think I have addressed the maintainer's comments and concerns.

docs/sphinx/source/whatsnew/v0.10.4.rst Outdated Show resolved Hide resolved
pvlib/tests/test_pvarray.py Outdated Show resolved Hide resolved
pvlib/tests/test_pvarray.py Outdated Show resolved Hide resolved
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriesse
Copy link
Member

We have one thing that is not fully resolved:

AFAIK Huld does not fully describe his fitting method, so a discussion may be needed to assess whether this requires a new publication. See #1898.

I would suggest this PR join the queue, and perhaps more discussion will ensue. The upcoming PVPMC is also a great opportunity to discuss and perhaps develop a policy.

@kandersolar kandersolar modified the milestones: v0.10.5, 0.11.0 May 3, 2024
@kandersolar kandersolar modified the milestones: 0.11.0, v0.11.1 Jun 21, 2024
@RDaxini
Copy link
Contributor

RDaxini commented Sep 21, 2024

We have one thing that is not fully resolved:

AFAIK Huld does not fully describe his fitting method, so a discussion may be needed to assess whether this requires a new publication. See #1898.

I would suggest this PR join the queue, and perhaps more discussion will ensue. The upcoming PVPMC is also a great opportunity to discuss and perhaps develop a policy.

Has anyone tried contacting Thomas Huld or any of the other authors to ask what fitting method was used?

@cwhanse
Copy link
Member Author

cwhanse commented Sep 21, 2024

Has anyone tried contacting Thomas Huld or any of the other authors to ask what fitting method was used?

I have reached out to several of the authors and have gotten no response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants