Skip to content

Revert "Rename pvwatts to pvwattsv5 everywhere (#1558)" #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Dec 20, 2022

This reverts commit e6e5b04.

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Following discussion in #1608

@kandersolar kandersolar added this to the 0.9.4 milestone Dec 20, 2022
@kandersolar kandersolar marked this pull request as ready for review December 20, 2022 17:42
@kandersolar kandersolar mentioned this pull request Dec 20, 2022
9 tasks
@kandersolar
Copy link
Member Author

Codecov isn't loading for me so I'll just assume the coverage drop is the usual drop when deleting covered lines. I'll also assume no objection to merging this :) Further discussion on the topic of what to do with PVWatts functionality can happen back in #1350.

@kandersolar kandersolar merged commit f5fc123 into pvlib:main Dec 20, 2022
@kandersolar kandersolar deleted the pvwatts-undo branch December 20, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant