-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use scipy.constants #1617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scipy.constants #1617
Conversation
The new minimum scipy must also be specified in setup.py's I didn't do an exhaustive search, but at least |
I searched but am not confident, because I didn't find that instance in temperature.py. I'm inclined to leave that one as is, with a comment. |
One more place to update the minimum scipy version: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we note the minimum version change in the release notes? I can go either way.
I vote yes and am a fan of the format we've used previously: |
Thanks everyone for seeing this through, including chasing down all the related “homework” items. |
docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.In review of #1573 @markcampanelli pointed out that the precisely calculated solutions to the single diode equation should use the latest values of physical constants (Boltzmann and elementary charge). In 2019, the various committees agreed that the published values of these two constants were exact, without uncertainty. (I link to the U.S. agency NIST, other national agencies also published the same values).
With this agreement I see no reason for pvlib to use approximate values anywhere. Scipy 1.4.0 published the agreed-upon exact values in
scipy.constants
. Advancing to scipy 1.4.0 does not require pvlib to also advance the numpy version.