-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligment POC Lias #886
base: main
Are you sure you want to change the base?
Aligment POC Lias #886
Conversation
26e7dec
to
d04f222
Compare
2dde360
to
fcf756b
Compare
d9abcb5
to
3ad8a14
Compare
backend/src/main/java/ch/puzzle/okr/service/business/AlignmentBusinessService.java
Show resolved
Hide resolved
b5e474c
to
b34d987
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hallo Lias,
habe den Server Teil angeschaut. Fazit: super gut umgesetzt. Ich habe noch ein paar Kommentare gemacht. Aus meiner Sicht könnte man da den Code noch etwas lesbarerer machen. Wenn du was davon umsetzten wäre das super ... aber Code passt sonst schon gut.
backend/src/main/java/ch/puzzle/okr/mapper/ObjectiveMapper.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/service/business/AlignmentBusinessService.java
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/service/business/AlignmentBusinessService.java
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/service/business/AlignmentBusinessService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/service/business/AlignmentBusinessService.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/service/business/ObjectiveBusinessServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/service/business/ObjectiveBusinessServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/service/business/ObjectiveBusinessServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/service/persistence/AlignmentPersistenceServiceIT.java
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/service/validation/AlignmentValidationServiceTest.java
Outdated
Show resolved
Hide resolved
df4a852
to
1d2e198
Compare
This branch has been rebased and fixed in #1174 |
Implementation of frontend management for alignments + New Diagram of Alignments:
Information for Alignment:
Alignment Management in Objective-Dialog
Information for Diagram