Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/1220 sonar code smells and risks #1272

Merged
merged 55 commits into from
Jan 10, 2025
Merged

Fix/1220 sonar code smells and risks #1272

merged 55 commits into from
Jan 10, 2025

Conversation

kcinay055679
Copy link
Collaborator

No description provided.

@kcinay055679 kcinay055679 linked an issue Jan 7, 2025 that may be closed by this pull request
Sonar Code Smells and Risks #1220
Closed
3 tasks
@kcinay055679 kcinay055679 force-pushed the fix/1220-sonar-code-smells-and-risks branch 3 times, most recently from f9219cb to f451f09 Compare January 9, 2025 11:45
@MasterEvarior @kcinay055679
Add workflow to keep track of progress
7464857
@MasterEvarior @kcinay055679
Remove empty constructors
fe9b7d3
@MasterEvarior @kcinay055679
Replace casts with instanceof operator
a2cd0e0
@MasterEvarior @kcinay055679
Replace wrappers with primitive types
7bb915b
@MasterEvarior @kcinay055679
Make public static variables also final
d24c98b
@MasterEvarior @kcinay055679
Fix wrong logger
db861ec
@MasterEvarior @kcinay055679
Remove unnecessary parentheses
6cf37fd
@MasterEvarior @kcinay055679
Replace deprecated constructor
e7aed40
@MasterEvarior @kcinay055679
Remove unnecessary assertion
7534140
@MasterEvarior @kcinay055679
Add private constructors for static utility classes
1c1a881
@MasterEvarior @kcinay055679
replace Collectors.toList() with toList()
3fa5f9f
@MasterEvarior @kcinay055679
Replace string concatenation with log formatting
84813f0
@MasterEvarior @kcinay055679
Replace comments with JavaDoc
edc0759
@MasterEvarior @kcinay055679
Remove unused logger
acf604f
@MasterEvarior @kcinay055679
Remove unused imports
e22ee36
@MasterEvarior @kcinay055679
Remove empty SCSS files
5094a3d
@MasterEvarior @kcinay055679
Invoke methods in logging statements only conditionally
4c32626
@MasterEvarior @kcinay055679
Add missing @OverRide annotation
ae0df0a
@MasterEvarior @kcinay055679
Rename generic according to single letter convention
301291d
@MasterEvarior @kcinay055679
Invoke methods in logging statements only conditionally
8bf9bd3
@MasterEvarior @kcinay055679
Remove unused imports
151dcfe
@MasterEvarior @kcinay055679
Replace RuntimeException with more specific exceptions
bac39b6
@MasterEvarior @kcinay055679
Suppress SonarQube rule where it is appropriate
f7f9d1c
@MasterEvarior @kcinay055679
Move log message to constant
4b3af36
@MasterEvarior @kcinay055679
Deconstruct array before sorting, so the original value does not get …
91125e2 
…overwritten
@MasterEvarior @kcinay055679
Rename logger to no overwrite field of parent class
457519b
MasterEvarior and others added 23 commits January 9, 2025 15:56
@MasterEvarior @kcinay055679
Make ErrorDto serializable to also make the OkResponseStatusException…
4b8a1e1 
… correctly serializable
@MasterEvarior @kcinay055679
Only allow safe HTTP method calls for static resources
92c13c5
@MasterEvarior @kcinay055679
Remove unused loading of SVG icons directly from resource URL
dcaad2d
@kcinay055679
fix after rebase
232f3d2
@kcinay055679
run frontend formatter
5511e14
@kcinay055679
apply backend formatter
7d6bc8b
@kcinay055679
clean up simple code smells
d47c1ed
@kcinay055679
resolve complex code smells
5f87cf3
@kcinay055679
fix tests
9f86358
@kcinay055679
apply formatter
4a27229
@kcinay055679
update package-lock
27b9ed8
@kcinay055679
remove all sonar bugs
ca6c980
@kcinay055679
readd jest to dev dependencies
3d2d58f
@kcinay055679
fix action test and add db migration
00b747c
@kcinay055679
fix h2 schema and test data
fa2c169
@kcinay055679
run formatter
f0d7084
@kcinay055679
fix all sonar bugs
b42fdc1
@kcinay055679
update sonarconfig
3ceb085
@kcinay055679
update sonar config
e7fc916
@kcinay055679
update sonar properties
3104760
@kcinay055679
update sonar config
55308d3
@kcinay055679
add tests for ObjectiveAfterActions
6f7fc85
@kcinay055679
fix e2e tests
727f441
@kcinay055679 kcinay055679 force-pushed the fix/1220-sonar-code-smells-and-risks branch from 3784d61 to 727f441 Compare January 9, 2025 14:59
@kcinay055679 kcinay055679 marked this pull request as ready for review January 9, 2025 15:03
@kcinay055679 kcinay055679 requested a review from peggimann January 9, 2025 15:03
@peggimann peggimann merged commit dd285e5 into main Jan 10, 2025
19 checks passed
@peggimann peggimann deleted the fix/1220-sonar-code-smells-and-risks branch January 10, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peggimann peggimann peggimann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sonar Code Smells and Risks
3 participants
@kcinay055679 @peggimann @MasterEvarior