add check for get last checkin ordinal

puzzle · Nov 21, 2024 · 35ef5ea · 35ef5ea
1 parent 0fcc86b
commit 35ef5ea
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/backend/src/main/java/ch/puzzle/okr/mapper/keyresult/KeyResultOrdinalMapper.java b/backend/src/main/java/ch/puzzle/okr/mapper/keyresult/KeyResultOrdinalMapper.java
@@ -86,7 +86,7 @@ public KeyResult toKeyResultOrdinal(KeyResultOrdinalDto keyResultOrdinalDto) {
 
     public KeyResultLastCheckInOrdinalDto getLastCheckInDto(Long keyResultId) {
         CheckIn lastCheckIn = checkInBusinessService.getLastCheckInByKeyResultId(keyResultId);
-        if (lastCheckIn == null) {
+        if (!(lastCheckIn instanceof CheckInOrdinal)) {
             return null;
         }
         return new KeyResultLastCheckInOrdinalDto(lastCheckIn.getId(), lastCheckIn.getVersion(),