Fix crashes #443
Merged
Fix crashes #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes crashes by updating dependency versions and refining the build and test processes. Key changes include updating dependency versions in Package.swift, Cartfile, and Cartfile.resolved; modifying the test mock implementation in Tests/Helpers/Mocks.swift; and enhancing various build scripts and CI workflows to improve build robustness with both Carthage and Swift Package Manager.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Helpers/Mocks.swift | Modified the resume method to invoke the completion handler synchronously to avoid race conditions. |
| Scripts/ensure-dependencies.sh | Added SPM fallback logic and marker files to support dependency resolution. |
| Scripts/debug-carthage-build.sh | Introduced a troubleshooting script for diagnosing Carthage build issues. |
| Package.swift | Bumped dependency versions to use the newer releases. |
| Consumption-Tests/Shared/carthage.sh | Enhanced the Carthage build script with retry logic and fallback build strategies. |
| Cartfile & Cartfile.resolved | Updated dependency version constraints accordingly. |
| .github/workflows/release.yml | Updated Xcode version, added steps to clear caches, and conditionally select a build strategy. |
| .github/workflows/ci.yml | Revised CI configuration with updated cache keys, conditional build/test steps, and Xcode version upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request
...
Why is the change necessary?
...