Push notifications #222
Push notifications #222
Conversation
|
(Copied from end of thread in #221) cc @lukeredpath We need to do some sort of a release (it doesn't need to be a 1.7, although that would be my preference) just to make sure that customers wanting to use the new native push feature that we've released (https://pusher.com/docs/push_notifications) can do so in their iOS (Objective-C) apps. In terms of it being Swift vs Obj-C I'll admit that I'm not clued up enough to know about the implications of using both in a library. Would we need to swap to using dynamic frameworks (as mentioned in #219)? |
…fications in beta
hamchapman
force-pushed
the
push-notifications
branch
from
213d979 to
bd0960a
Compare
Report library version and name to push notifications api
|
@hamchapman I know you're keen to try and get something out there but I'm not really happy with this code as I don't feel it meets the quality standard I want to try and maintain. As such I'm not really happy to merge this so it might be worth considering wrapping this up as a standalone extension that users can add to their project separately. |
[push notifications] Fix typo in delegate callback check
|
@hamchapman: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@hamchapman: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hamchapman: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Replacing #221 as this has the desired branch name