[Do not merge] - Python - DEVTOOLING-997 #1019
Conversation
sureshperiyappan
requested review from
dginty4,
carnellj-genesys,
HemanthDogiparthi12 and
charliecon
as code owners
sureshperiyappan
changed the title
| # Authenticate with client credentials and pass the apiclient instance into the usersapi | ||
| print("Authenticating with client credentials...") | ||
| SdkTests_mtls.apiclient_mtls = PureCloudPlatformClientV2.api_client.ApiClient() | ||
| SdkTests_mtls.apiclient_mtls.set_gateway("locahlost","https",4027,"login","api") |
There was a problem hiding this comment.
this could be the problem for 404 error, "localhost"
There was a problem hiding this comment.
That error I already corrected. see here https://bitbucket.org/inindca/platform-client-sdk-internal-config/commits/56b04225ef115fb9e798eee431b442aba43467a6 this is the one that I can run in the Jenkins JOB.
https://jenkins.ininica.com/job/build-platform-sdks-internal-pipeline/5853/console
…y, moved rest.py to extensions
|
Some explanations on how to use (Client Injection) or set (Proxy, MTLS) these new capabilities need to be added to the /resources/sdk/purecloudpython/templates/README.mustache file. |
There was a problem hiding this comment.
Why is this change done in this new rest.py file and not in the templates/rest.mustache one?
There was a problem hiding this comment.
For the following reason the "templates/rest.mustache" has been move to "extensions/rest.py":
1)The relocation of "templates/rest.mustache" to "extensions/rest.py" aligns with the Client Injection approach, positioning the default HTTP client "rest.mustache" within the extensions directory, as discussed with @HemanthDogiparthi12 .
2)Given that "rest.mustache" lacks any template-specific code, its placement within the extensions folder is logical.
3)Due to the absence of other code dependencies, this move is not anticipated to cause any adverse effects.
4)Although unlikely, there's a potential for regression if any client implementation directly references this file.
There was a problem hiding this comment.
The OpenAPI Generator for purecloudpython is expecting it
|
Separate PR #1060 has been put for MTLS changes alone |
Testing completed:
https://jenkins.ininica.com/job/build-platform-sdks-internal-pipeline/5884/
ReadMe yet to be updated