rktl Comments and Documentation #147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameters to the sim.py object
added comments for the specific functions changed comment structure for old functions
included comments for new return values as global variables in the object
1:moved sim environment paramters to the init fucntions 2:created update function that calls the create car function, and does not create new subscribers 3:all paramters now use custom get_sim_param function for generation of properties 4:added comments about todos in sim.py
1. split up init function into get_car_properties and rest 2. reset function: clears the system state - resets the car to the desired position and orientation given an input of values 3. added comments to explain what these functions do
…rent =true parameter
enabled creating cars and generating ball without reseting all of the sim refactored create_car_cb, delete_car_cb, reset_cb to work better added some documentation and comments fixed bugs with calling rospy.getsimparam over self.getsimparam
add pfilter to dockerfile
add pull argument to docker build call in server run
…to fix with try catch
Update .gitignore, removes stupid DSstore file! lets go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comments for the parameters, return, and overview of each function in the following locations:
rktl_sim/src/simulator/sim.py
rktl_sim/nodes/simulator
rktl_autonomy/nodes/rocket_league_agent
rktl_autonomy/src/rktl_autonomy/_ros_interface.py
rktl_autonomy/src/rktl_autonomy/rocket_league_interface.py
rktl_autonomy/scripts/train_rocket_league.py
Note: I marked questions/things that I did not know with "TODO:"+ some text.