allow librarian exclusion declaration as a noop #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
Sep 9, 2024
puppet/r10k has a dep on choria/mcollective for functionality which is not used by lsst and this mod is not delcared in the `Puppetfile`. choria/mcollective has dep constraints which are preventing an upgrade of the puppet/systemd mod. librarian-puppet has the ability to ignore mods with an `exclusion` directive. r10k does not currently support `exclusion`. As a horrible hack, we are injecting the `exclusion` directive only in the librarian-puppet workflow so as not to break r10k. See: puppetlabs/r10k#1400
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
Sep 9, 2024
puppet/r10k has a dep on choria/mcollective for functionality which is not used by lsst and this mod is not delcared in the `Puppetfile`. choria/mcollective has dep constraints which are preventing an upgrade of the puppet/systemd mod. librarian-puppet has the ability to ignore mods with an `exclusion` directive. r10k does not currently support `exclusion`. As a horrible hack, we are injecting the `exclusion` directive only in the librarian-puppet workflow so as not to break r10k. See: puppetlabs/r10k#1400
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
Sep 9, 2024
puppet/r10k has a dep on choria/mcollective for functionality which is not used by lsst and this mod is not delcared in the `Puppetfile`. choria/mcollective has dep constraints which are preventing an upgrade of the puppet/systemd mod. librarian-puppet has the ability to ignore mods with an `exclusion` directive. r10k does not currently support `exclusion`. As a horrible hack, we are injecting the `exclusion` directive only in the librarian-puppet workflow so as not to break r10k. See: puppetlabs/r10k#1400
|
This PR has been marked stale because it has had no activity for 60 days. If you are still interested in getting this merged, please comment and we'll try to move it forward. Otherwise, it will be closed in 7 days. |
|
Bueller? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.