Skip to content

(PE-39731) Log request info on failure or cancellation #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025
Merged

(PE-39731) Log request info on failure or cancellation #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/java/com/puppetlabs/http/client/impl/JavaClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ private static void completeResponse(ResponseDeliveryDelegate responseDeliveryDe
contentType,
callback);
} catch (Exception e) {
LOGGER.error("Processing successful request to {} raised '{}'", requestOptions.getUri().toString(), e.getMessage());
responseDeliveryDelegate.deliverResponse(requestOptions, e, callback);
}
}
Expand Down Expand Up @@ -479,11 +480,13 @@ public void completed(HttpResponse httpResponse) {

@Override
public void failed(Exception e) {
LOGGER.error("{} request to '{}' failed.", method.toString(), requestOptions.getUri().toString());
responseDeliveryDelegate.deliverResponse(requestOptions, e, callback);
}

@Override
public void cancelled() {
LOGGER.error("{} request to '{}' cancelled.", method.toString(), requestOptions.getUri().toString());
responseDeliveryDelegate.deliverResponse(requestOptions,
new HttpClientException("Request cancelled"),
callback);
Expand Down
Loading