Skip to content

Conversation

SugatD
Copy link

@SugatD SugatD commented Oct 15, 2025

Summary

  • Ensure the acceptance job name correctly shows the collection value whether matrix.collection is provided as a string or as an object.
  • This fixes display/label correctness in workflow runs and prevents misleading job names when matrix.collection is an object.

Checklist

  • 🟢 Verified the YAML change is syntactically valid YAML.
  • 🟢 Triggered an acceptance test - WORKING CI
  • Manually verified.

@SugatD SugatD requested review from a team as code owners October 15, 2025 14:18
@SugatD SugatD changed the title Handle object or string matrix.collection in acceptance job name (CAT-2478) Handle object or string matrix.collection in acceptance job name Oct 16, 2025
@skyamgarp
Copy link
Contributor

skyamgarp commented Oct 17, 2025

Hi @SugatD ,
can you please add any execution where this change is tested in both the cases?
Also, would it be better to check first if collection.collection has value and then use it?

@SugatD
Copy link
Author

SugatD commented Oct 17, 2025

Hello @skyamgarp

Link for executed CI is mentioned in Description

Adding reference again, kindly review -> https://github.com/puppetlabs/puppetlabs-facter_task/actions/runs/18457669754/workflow

@skyamgarp
Copy link
Contributor

  • WORKING CI

Thanks, I wanted to know if code change after OR part works fine if there is no collection.collection

@SugatD
Copy link
Author

SugatD commented Oct 17, 2025

When matrix.collection is a string (e.g., "puppetcore8-nightly"): https://github.com/puppetlabs/puppetlabs-facter_task/actions/runs/18585871953/job/52989598235

matrix.collection.collection will evaluate to null
So the expression becomes null || matrix.collection
And it falls back to matrix.collection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants