Update agent download from URL logic to handle redirects #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
==========================================
- Coverage 78.07% 77.71% -0.36%
==========================================
Files 15 15
Lines 1596 1602 +6
==========================================
- Hits 1246 1245 -1
- Misses 350 357 +7
Continue to review full report at Codecov.
|
joshcooper
reviewed
Feb 15, 2022
cthorn42
force-pushed
the
maint/master/fix_redirect_in_agent_download
branch
from
1b64cbb
to
31c3259
Compare
bastelfreak
reviewed
Feb 15, 2022
cthorn42
force-pushed
the
maint/master/fix_redirect_in_agent_download
branch
2 times, most recently
from
ead2c73
to
0b277c6
Compare
|
I think the ruby 3.0.3 failure is due to rspec/rspec-expectations#1350 |
joshcooper
reviewed
Feb 18, 2022
joshcooper
reviewed
Feb 18, 2022
cthorn42
force-pushed
the
maint/master/fix_redirect_in_agent_download
branch
from
0b277c6
to
8209f0e
Compare
joshcooper
reviewed
Feb 22, 2022
Recent internal changes have caused http URLs to be redirected to HTTPs for nightlies.puppet.com. This breaks the agent download from URL, but this PR adds in some redirect logic that will fix the issue.
cthorn42
force-pushed
the
maint/master/fix_redirect_in_agent_download
branch
from
8209f0e
to
cdc9608
Compare
joshcooper
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
LGTM @bastelfreak or @ekohl any concerns about this?
Also are the code coverage checks useful? I'm not a huge fan myself.
bastelfreak
approved these changes
Feb 22, 2022
Merged
cthorn42
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent internal changes have caused http URLs to be redirected to HTTPs
for nightlies.puppet.com. This breaks the agent download from URL, but
this PR adds in some redirect logic that will fix the issue.