fix: prevent close listener leak on rapid tunnel reconnections - #2
Merged
Merged
Conversation
Owner
|
Just a minor lint issue |
Contributor
Author
Fixed, PTAL |
|
I'm experiencing this too. Any chance this can get merged @punkpeye 🙏? |
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
MaxListenersExceededWarningthat shows up when tunnels reconnect a lot.Every time a tunnel socket opens, we register a
closehandler on theTunnelso we can clean up if someone callstunnel.close(). That handler gets removed when the socket fires itscloseevent.The problem is when a socket dies and we immediately open a replacement — the old socket hasn't fired
closeyet (it's async), so its handler is still hanging around when the new one gets added. Do this enough times and handlers pile up until Node starts complaining.Instead of waiting for the socket's
closeevent to clean up, we do it right away when we know the socket is dead:TunnelClusternow passes the dead socket reference along with thedeadeventTunnelkeeps a map of socket → handler, and removes the entry as soon asdeadfireslistenerCount('close')stays flat